-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Grid/List toggle for Media Browser #18256
Conversation
We can also get radio list thumbnails by setting Several other classes already have grid layout with show_list_images, so I'm not sure why some would have that combination and others not.
|
That is great - being able to read the station names is a huge step forward! Is it possible (or easy) to add other values from the radio browser data base? An indicator of the bitrate would allow differentiation where it isn't included in the station name and there are multiple versions available. |
I haven't actually looked at what metadata is available to the list renderer or how it works. This was a pretty simple PR as the list renderer already existed, and I just need to flip a boolean to turn it on. But I haven't actually delved into yet how it operates. I think I will leave further enhancements to list rendering to another PR; don't have any immediate plans to personally delve into it, but maybe someday. |
Fair enough. This is a really helpful improvement for anyone using Radio Browser! |
I like this a lot, but for the UX, I think the list should have 3 options, @matthiasdebaat What do you think? |
I started with this, but then I gave up trying to find an mdi icon for |
There was some discussion about this PR, regarding UX, that adding these options could cause confusion, as it is not clear what |
I agree that an Auto option really isn't clear - what decision is being made automatically? Why is this better than just having a well chosen default that can be overridden when it doesn't work for the user? For Radio Browser the grid display leaves the feature barely useable since it isn't possible to differentiate between different options. A grid view is most useful where the most specific information is at the start of the media title, unless the image used in the grid tile shows specific information. In a well curated music collection where track numbers are at the start of the filename, grid view may work well. For Radio Browser this is definitely not the case, and users have no way of changing how Radio Browser (or thousands of individual radio stations) have decided to make entities - so it isn't something a user can resolve. Being able to switch between grid and list view is a better compromise, and at least makes Radio Browser more useful immediately. |
Never dealt with radio...
|
@bramkragten I'm confused what the status of this is. Your initial comment sounded like a reject, but then you pushed additional changes to the PR, so I'm not sure what we're doing with this. |
Haha 😅 I'm going to discuss this with UX, will get back to you tomorrow. Personally I think it is a great feature, we just need to get the UX right :-) |
5f932c8
to
682c91b
Compare
Proposed change
Add a grid/list toggle for media browser in the top right corner overflow menu. When neither item is selected, the choice will be automatic (current behavior). Choosing one of the options sets the browser to force render in grid/list mode. Choosing it a second time reverts back to automatic behavior.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: